Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating tf2 C Headers #4828

Merged

Conversation

CursedRock17
Copy link
Contributor

@CursedRock17 CursedRock17 commented Oct 28, 2024

Related to this pull request in geometry2 in which we deprecated the .h style headers in favor of .hpp.

Edit: I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues

Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@CursedRock17
Copy link
Contributor Author

With the recent backports merged, this PR should be good for review.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this should not be backported to other distributions, as this is Rolling-only for now.

@clalancette clalancette merged commit 2f740f5 into ros2:rolling Dec 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants