add explanation about component containers. #4902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christophebedard @clalancette can you take a look? thanks in advance. |
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
fujitatomoya/add-component-container
branch
from
94bf175 to
965d922
Compare
fujitatomoya
requested review from
christophebedard and
clalancette
and removed request for
clalancette
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12440041148/artifacts/2350767133. To view the resulting site:
|
fujitatomoya
commented
Dec 13, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
fujitatomoya
force-pushed
the
fujitatomoya/add-component-container
branch
from
2839672 to
f3aad80
Compare
|
@christophebedard thanks for doing review on this, most of your comments are addressed by f3aad80 just fyi, since i borrowed most of your suggestions, that put you as Co-Author. |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@christophebedard thanks for checking on this, all comments are addressed. requesting review once again. |
| * Component container that uses a dedicated executor for each component: either ``SingleThreadedExecutor`` (default) or ``MultiThreadedExecutor``. | ||
|
|
||
| For more information about the types of executors, see the :ref:`TypesOfExecutors`. | ||
| For more information about the option of each component container, see :ref:`ComponentContainerTypes` in the composition tutorial. |
There was a problem hiding this comment.
Suggested change
| For more information about the option of each component container, see :ref:`ComponentContainerTypes` in the composition tutorial. | |
| For more information about the options of each component container, see :ref:`ComponentContainerTypes` in the composition tutorial. |
My bad, sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4901