Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Extra Arguments for Component Manager. #4904

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from
Open

add Extra Arguments for Component Manager. #4904

wants to merge 3 commits into from

Conversation

fujitatomoya
Copy link
Collaborator

follow-up of ros2/rclcpp#2685

@fujitatomoya
add Extra Arguments for Component Manager.
2bb0b45 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@mjcarroll can you take a look?

fujitatomoya
fujitatomoya commented Dec 14, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that jazzy and humble supports only use_intra_process_comms and forward_global_arguments, so we cannot backport this to jazzy and humble as it is.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2024 •
edited
Loading

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12402722626/artifacts/2340456314.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4904/index.html in your favorite browser

@fujitatomoya
move the command line example before the table.
1991c68 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya requested a review from kscottz December 17, 2024 04:30
kscottz
kscottz approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is fixed. LGTM.

clalancette
clalancette requested changes Dec 18, 2024
View reviewed changes
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Intermediate/Composition.rst Outdated Show resolved Hide resolved
@fujitatomoya
address review comments.
8c0112b 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@clalancette all your comments are addressed in 8c0112b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kscottz kscottz kscottz approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

@clalancette clalancette Awaiting requested review from clalancette clalancette is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @clalancette @kscottz