Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add release note about changed signature #606

Merged
merged 2 commits into from
Apr 14, 2020
Merged

add release note about changed signature #606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ad5ad
add release note about changed signature
wjwwood Apr 14, 2020
e9b4ade
fixup
wjwwood Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions source/Releases/Release-Foxy-Fitzroy.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,20 @@ For examples, see the `relevant changes to the demos. <https://github.com/ros2/d

`Related pull request in launch_ros. <https://github.com/ros2/launch_ros/pull/122>`_

rclcpp
^^^^^^

Change in Advanced Subscription Callback Signature
""""""""""""""""""""""""""""""""""""""""""""""""""

With the pull request [https://github.com/ros2/rclcpp/pull/1047](https://github.com/ros2/rclcpp/pull/1047) the signature of callbacks which receive the message info with the message has changed.
Previously it used the ``rmw`` type ``rmw_message_info_t``, but now uses the ``rclcpp`` type ``rclcpp::MessageInfo``.
The required changes are straightforward, and can be seen demonstrated in these pull requests:

- [https://github.com/ros2/system_tests/pull/423/files](https://github.com/ros2/system_tests/pull/423/files)
- [https://github.com/ros2/rosbag2/pull/375/files](https://github.com/ros2/rosbag2/pull/375/files)
- [https://github.com/ros2/ros1_bridge/pull/253/files](https://github.com/ros2/ros1_bridge/pull/253/files)

rclpy
^^^^^

Expand Down