Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install RTI version of openssl on OSX #662

Merged
merged 4 commits into from
May 8, 2020
Merged

Install RTI version of openssl on OSX #662

merged 4 commits into from
May 8, 2020

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented May 7, 2020 •
edited
Loading

Needed for ros2/sros2#209

Alternative to ros2/ci#436

@sloretz sloretz self-assigned this May 7, 2020
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-662 May 7, 2020 19:16 Inactive
clalancette
clalancette reviewed May 7, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to add these instructions into https://index.ros.org/doc/ros2/Installation/Foxy/macOS-Development-Setup/ for the from-source users?

source/Contributing/Set-up-a-new-macOS-CI-node.rst Outdated
@@ -136,6 +136,19 @@ RTI Connext Specific Instructions
* Set the shared memory parameters from https://community.rti.com/kb/osx510

* Do not bother to reboot yet.

* Download ``openssl-1.0.2n-target-x64Darwin17clang9.0.tar.gz`` and extract it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would I get this from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added hint about where to get it in c85a837

source/Contributing/Set-up-a-new-macOS-CI-node.rst Outdated Show resolved Hide resolved
@sloretz
Copy link
Contributor Author

sloretz commented May 7, 2020

Do we also need to add these instructions into https://index.ros.org/doc/ros2/Installation/Foxy/macOS-Development-Setup/ for the from-source users?

It kind of, sort of, already maybe is?

Extract and Install OpenSSL This is included as an archive (.zip or otherwise) and can be simply extracted and copied to a convenient location on your host computer. As a suggestion, this could also be installed into the ‘rti_connext_dds-[version]’ directory in your home directory space (this was created during installation of the RTI host tools). Note: this directory location may need to be placed in your PATH environment variable.

https://index.ros.org/doc/ros2/Installation/Install-Connext-Security-Plugins/

sloretz added a commit that referenced this pull request May 7, 2020
@sloretz
Add note about extracting RTI provided openssl
616da2e 
Relates to #662
@sloretz sloretz mentioned this pull request May 7, 2020
Merged
@sloretz @clalancette
Update source/Contributing/Set-up-a-new-macOS-CI-node.rst
f6e8b75 
Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-662 May 7, 2020 19:32 Inactive
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-662 May 7, 2020 19:33 Inactive
@jacobperron
Copy link
Member

AFAIU, this shouldn't really affect users, since the patch involving RTI_OPENSSL_* is solely a workaround for running tests on machines with multiple openssl installations (right?). So, I think the documentation here is enough.

@sloretz sloretz merged commit 154be02 into master May 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the sloretz/rti_openssl branch May 8, 2020 18:52
sloretz added a commit that referenced this pull request May 8, 2020
@sloretz
Add note about extracting RTI provided openssl (#664)
911000c 
* Add note about extracting RTI provided openssl

Relates to #662

* Link to RTI documentation
ferranm99 added a commit to ferranm99/ferran-ros that referenced this pull request May 20, 2022
@ferranm99
Add note about extracting RTI provided openssl (#664)
5981e94 
* Add note about extracting RTI provided openssl

Relates to ros2/ros2_documentation#662

* Link to RTI documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette left review comments

@jacobperron jacobperron jacobperron approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees

@sloretz sloretz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sloretz @jacobperron @clalancette @mjcarroll