-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Foxy release notes. #704
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
3a4399c
to
986c621
Compare
The note sounds a bit too general to me. What does "performance is unreliable" actually mean is probably the first answer every reader will have. |
What about using the word "flaky" instead? We could also expand the note to detail that the problem is service clients sometimes do not receive the response from servers. |
That would be good so the user know the symptom. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@dirk-thomas @jacobperron PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that we have to document this as a known issue is 😞 but the patch itself lgtm.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
On a positive note, ADLINK folks may land a workaround soon 😃. See ros2/rmw_cyclonedds#187. |
Added release note about ros2/ros2#922.