Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Foxy release notes. #704

Merged
merged 3 commits into from
May 21, 2020
Merged

Update Foxy release notes. #704

merged 3 commits into from
May 21, 2020

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented May 20, 2020

Added release note about ros2/ros2#922.

@hidmic hidmic requested a review from jacobperron May 20, 2020 17:25
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-704 May 20, 2020 17:25 Inactive
@hidmic
Update Foxy release notes.
986c621 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/update-foxy-release-notes branch from 3a4399c to 986c621 Compare May 20, 2020 17:25
@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-704 May 20, 2020 17:26 Inactive
@dirk-thomas
Copy link
Member

The note sounds a bit too general to me. What does "performance is unreliable" actually mean is probably the first answer every reader will have.

@jacobperron
Copy link
Member

The note sounds a bit too general to me. What does "performance is unreliable" actually mean is probably the first answer every reader will have.

What about using the word "flaky" instead? We could also expand the note to detail that the problem is service clients sometimes do not receive the response from servers.

@dirk-thomas
Copy link
Member

We could also expand the note to detail that the problem is service clients sometimes do not receive the response from servers.

That would be good so the user know the symptom.

@hidmic
Address peer review comments.
bfd4264 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented May 20, 2020

@dirk-thomas @jacobperron PTAL

@mjcarroll mjcarroll temporarily deployed to ros2-documentation-pr-704 May 20, 2020 21:55 Inactive
dirk-thomas
dirk-thomas approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that we have to document this as a known issue is 😞 but the patch itself lgtm.

@hidmic
Fix bad rst syntax.
211797f 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented May 20, 2020 •
edited
Loading

The fact that we have to document this as a known issue is 😞

On a positive note, ADLINK folks may land a workaround soon 😃. See ros2/rmw_cyclonedds#187.

@hidmic hidmic merged commit 4865116 into master May 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/update-foxy-release-notes branch May 21, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hidmic @dirk-thomas @jacobperron @mjcarroll