Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to run coverage #737
Add instructions to run coverage #737
Changes from all commits
d285f9b
9537ad0
08878a0
0555302
79b0fbe
88678fe
0dc590e
9450ee9
a438fb9
6f7fb29
9a5c089
329a376
161f6a0
186bf88
eb1dcd3
384450c
c4e8dec
1fc2b56
ac15aba
a4cec8a
1e2cbea
3325c7a
691bc90
c9494a6
eeda9b4
cf9cbad
3dc83fb
368ef92
194fc7c
bd12928
15d6aee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really recommend "external" scripts like this which have never been reviewed and are not accessible to edit by anyone else in the team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j-rivero is working on moving it to a more common location. Do you have a preference?
I reviewed the script while reviewing this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference - just not on a personal GitHub user. Please suggest proposals.
Just a view things I notices while briefly looking at it (and since I don't see any PR on that repo I will just post it here):
/usr/bin/env
stderr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully agree on moving it a better location. ros2/ci repository is the first one that comes to my mind.
Thanks for looking into it Dirk. I've updated the code with your findings but let's start a PR procedure to look into it deeper.