Switch from Travis -> Github actions. #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
(we'll also have to port this to the versioned branches) |
jacobperron
approved these changes
Dec 15, 2020
Comment on lines
+21
to
+25
| - run: make html 2> stderr.log | ||
| - run: cat stderr.log | ||
| - run: doc8 --ignore D001 --ignore-path build --ignore-path source/Tutorials/Actions | ||
| # ignore D000 in action tutorials to allow for :linenos: | ||
| - run: doc8 --ignore D000 --ignore D001 --ignore-path build source/Tutorials/Actions |
There was a problem hiding this comment.
I'm just curious why you chose to put each command in a separate run: entry versus something like
- run: |
make html 2> stderr.log
cat stderr.log
doc8 --ignore D001 --ignore-path build --ignore-path source/Tutorials/Actions
# ignore D000 in action tutorials to allow for :linenos:
doc8 --ignore D000 --ignore D001 --ignore-path build source/Tutorials/Actions
There was a problem hiding this comment.
If I'm being honest, I did it that way because the tutorial I was following did it that way :).
I don't feel strongly about it, but I actually like the separated run statements a bit better now that I see it deployed. Each separate run statement gets its own block, which makes it kind of easy to see exactly what failed when a step failed.
maryaB-osr
approved these changes
Dec 15, 2020
|
@Mergifyio backport rolling |
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2020
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit dab7090) # Conflicts: # .travis.yml
|
Command
|
clalancette
added a commit
that referenced
this pull request
Jan 4, 2021
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit dab7090)
clalancette
added a commit
that referenced
this pull request
Jan 5, 2021
maryaB-osr
pushed a commit
that referenced
this pull request
Jan 5, 2021
tfoote
pushed a commit
that referenced
this pull request
Apr 4, 2023
tfoote
added a commit
that referenced
this pull request
Apr 4, 2023
* Switch to use new GA4 analytics tag (#3421) The old one is being sunset and won't work for much longer (cherry picked from commit ac56356) # Conflicts: # conf.py * Fixing merge failure by adding theme and theme options Fixing syntax for backporting. We're using this theme so hopefully backporting the alternative settings will work too. * add missing requirements for build * Switch from Travis -> Github actions. (#948) (#953) Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit dab7090 and commit 9289f21) Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> * add rtd theme requirement Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai> --------- Signed-off-by: Tully Foote <tullyfoote@intrinsic.ai> Co-authored-by: Tully Foote <tfoote@osrfoundation.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Tully Foote <tullyfoote@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org