Add EOL banner to eloquent #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maryaB-osr <marya@openrobotics.org>
|
#991 targets this branch, so merge that before this one |
* Change the wording for version banners Signed-off-by: maryaB-osr <marya@openrobotics.org> * Apply suggestions from code review Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> * add commas to review change Signed-off-by: maryaB-osr <marya@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
approved these changes
Jan 11, 2021
|
I think it's worth noting here that we agreed EOL distro documentation should be kept on the site for 1 year after EOL, and then archived. We'll document this properly elsewhere, I just thought it might be helpful in the future to tie that concept to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nicer way would be to have an
eol_versionvariable instead of doing a string compare, but that would require some work on the plugin, so for now we'll just do it this way.Signed-off-by: maryaB-osr marya@openrobotics.org