-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rosidl specific logic to rosidl_runtime_py #218
Labels
Comments
Merged
This was referenced Nov 25, 2019
jacobperron
added a commit
that referenced
this issue
Dec 4, 2019
Connects to #218. Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError. The new logic added in ros2/rosidl_runtime_py#9 should fix the error. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Found another TODO; addressing it in #415. |
jacobperron
added a commit
that referenced
this issue
Dec 10, 2019
) Connects to #218. Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError. The new logic added in ros2/rosidl_runtime_py#9 should fix the error. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
All connected PRs have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature request
Feature description
There are several TODOs for moving rosidl-related logic to a rosidl package. Now that the rosidl_runtime_py package exists, it seems like a good place.
TODOs:
ros2cli/ros2msg/ros2msg/api/__init__.py
Lines 39 to 44 in 07640db
ros2cli/ros2msg/ros2msg/api/__init__.py
Lines 52 to 54 in 07640db
ros2cli/ros2msg/ros2msg/verb/show.py
Line 30 in 07640db
ros2cli/ros2srv/ros2srv/api/__init__.py
Lines 39 to 44 in 07640db
ros2cli/ros2srv/ros2srv/api/__init__.py
Lines 52 to 54 in 07640db
ros2cli/ros2srv/ros2srv/verb/show.py
Lines 30 to 31 in 07640db
ros2cli/ros2service/ros2service/verb/call.py
Line 60 in 07640db
Also, from ros2action being added in #214
The text was updated successfully, but these errors were encountered: