Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rosidl specific logic to rosidl_runtime_py #218

Closed
jacobperron opened this issue Apr 13, 2019 · 3 comments
Closed

Move rosidl specific logic to rosidl_runtime_py #218

jacobperron opened this issue Apr 13, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request in progress Actively being worked on (Kanban column)

Comments

@jacobperron
Copy link
Member

Feature request

Feature description

There are several TODOs for moving rosidl-related logic to a rosidl package. Now that the rosidl_runtime_py package exists, it seems like a good place.

TODOs:

# TODO(dirk-thomas) this logic should come from a rosidl related package
# Only return messages in msg folder
return list(sorted({
n[4:-4]
for n in interface_names
if n.startswith('msg/') and n[-4:] in ('.idl', '.msg')}))

# TODO(dirk-thomas) this logic should come from a rosidl related package
return os.path.join(
prefix_path, 'share', package_name, 'msg', message_name + '.msg')

# TODO(dirk-thomas) this logic should come from a rosidl related

# TODO(dirk-thomas) this logic should come from a rosidl related package
# Only return services in srv folder
return list(sorted({
n[4:-4]
for n in interface_names
if n.startswith('srv/') and n[-4:] in ('.idl', '.srv')}))

# TODO(dirk-thomas) this logic should come from a rosidl related package
return os.path.join(
prefix_path, 'share', package_name, 'srv', service_name + '.srv')

# TODO(dirk-thomas) this logic should come from a rosidl related
# package

# TODO(wjwwood) this logic should come from a rosidl related package

Also, from ros2action being added in #214

@jacobperron
Copy link
Member Author

I believe all of the TODOs are address by #371, #407, #405, and #406. Once they are merged I'll close this issue.

@jacobperron jacobperron self-assigned this Nov 25, 2019
@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Nov 27, 2019
jacobperron added a commit that referenced this issue Dec 4, 2019
Connects to #218.

Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError.
The new logic added in ros2/rosidl_runtime_py#9 should fix the error.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

Found another TODO; addressing it in #415.

jacobperron added a commit that referenced this issue Dec 10, 2019
)

Connects to #218.

Note that the action feedback logic in the echo verb was incorrect, resulting in a ModuleImportError.
The new logic added in ros2/rosidl_runtime_py#9 should fix the error.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

All connected PRs have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress Actively being worked on (Kanban column)
Projects
None yet
Development

No branches or pull requests

1 participant