Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning in ros2node when dealing with non-uniquely-named nodes #453

Closed
emersonknapp opened this issue Feb 19, 2020 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@emersonknapp
Copy link
Contributor

Feature request

Related to #279 - but a much simpler feature request

  • When running ros2 node list, add a top level warning and a small note next to all nodes that share a name, e.g.
$ ros2 node list
# WARNING: There are nodes in the graph that share a name - it is recommended that you use namespaces or different names to differentiate nodes
/talker (not uniquely named)
/listener
/talker (not uniquely named)
  • When running ros2 node info, add a note that you are receiving information about only one node with the given name, if multiple are present, e.g.
$ ros2 node info /talker
# WARNING: there is more than one node found that has the name /talker, you are seeing information about only one of them. It is not guaranteed that you will see information about the same node every time
etc...

This should help make the non-unique situation more obvious, even though it doesn't fix anything.

Implementation considerations

We should already have all the information we need, a sort and pass over the node list should do for both cases.

@hidmic
Copy link
Contributor

hidmic commented Apr 8, 2020

@emersonknapp as far as I can see, this issue has been fully addressed. I'll close it.

@hidmic hidmic closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants