Unignore fastcdr when building for connext. #148
Conversation
The new Connext RMW relies on fastcdr to do generation for it, so it won't build without it. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Connext needs the fastrtps rosidl typesupport packages. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Co-authored-by: Scott K Logan <logans@cottsay.net>
|
It turns out that we can't ignore fastrtps, since the rosidl_typesupport_fastrtps packages depend on it. In turn, that means we also cannot ignore foonathan_memory_vendor, which fastrtps depends on. So I'll remove both of those from the |
|
Here's a build using the current state of this PR: https://build.ros2.org/view/Rci/job/Rci__nightly-connext_ubuntu_focal_amd64/273 |
There was a problem hiding this comment.
LGTM.
Hopefully we can remove the dependency on fastrtps from rosidl_typesupport_fastrtps in the future. I asked @MiguelCompany about it (here), and I can open a PR on that repository if desired (and feasible... I will wait to hear back).
|
I'm going to go ahead and merge this to get this job at least yellow on the next nightlies. If there is any other review feedback, I'm happy to address it afterwards. |
delete-merged-branch
bot
deleted the
clalancette/rolling-connext-unignore-fastcdr
branch
The new Connext RMW relies on fastcdr to do generation for
it, so it won't build without it.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org