Don't warn for unknown types if topics are not in the list

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
ros2 · Sep 12, 2023 · fa84bbe · fa84bbe
1 parent 777612f
commit fa84bbe
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/rosbag2_transport/src/rosbag2_transport/topic_filter.cpp b/rosbag2_transport/src/rosbag2_transport/topic_filter.cpp
@@ -121,11 +121,6 @@ bool TopicFilter::take_topic(
     return false;
   }
 
-  const std::string & topic_type = topic_types[0];
-  if (!allow_unknown_types_ && !type_is_known(topic_name, topic_type)) {
-    return false;
-  }
-
   if (!record_options_.include_hidden_topics && topic_is_hidden(topic_name)) {
     RCUTILS_LOG_WARN_ONCE_NAMED(
       ROSBAG2_TRANSPORT_PACKAGE_NAME,
@@ -163,6 +158,11 @@ bool TopicFilter::take_topic(
     return false;
   }
 
+  const std::string & topic_type = topic_types[0];
+  if (!allow_unknown_types_ && !type_is_known(topic_name, topic_type)) {
+    return false;
+  }
+
   return true;
 }