Add the /bigobj flag to Windows Debug builds. #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows debug builds generate a lot more sections, so when building in debug mode we need to add the /bigobj flag to avoid failing the build. More details are in the link in the code comment. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
emersonknapp and
hidmic
and removed request for
a team
|
CI:
|
|
@Blast545 FYI |
|
@clalancette FYI It only happened on the last nightlies after #968 |
Blast545
approved these changes
May 11, 2022
sloretz
approved these changes
May 11, 2022
|
Test failures on linux https://ci.ros2.org/job/ci_linux/16681/ are a known flaky issue reported #862. |
|
CI is mostly green, and have approvals. Merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows debug builds generate a lot more sections, so when
building in debug mode we need to add the /bigobj flag to
avoid failing the build. More details are in the link in
the code comment.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This should fix the failing Windows Debug builds that have happened the last two nights, like https://ci.ros2.org/view/nightly/job/nightly_win_deb/2354/