set_read_order: return success

[james-rms]

This PR makes these changes:

1. Notes to client code that set_read_order should only be called after open(). There are cases where a storage plugin actually needs to read the underlying bag file in order to determine whether a given read order is supported. For example, if a timestamp index is required to read in timestamp order, the storage plugin needs to know whether that is present before accepting a request to read in timestamp order.
2. Throw an exception from within SequentialReader if read order is set before opening the underlying storage.
3. changes set_read_order to return a boolean for success or failure. This makes the flow for client code attempting to set a read order more ergonomic. Previously a client would have to check for a std::runtime_error and possibly inspect the exception text to ensure that the exception is about whether the read order is supported, rather than something unrelated.

[emersonknapp]

Gist: https://gist.githubusercontent.com/emersonknapp/e5759b670fc0136412f5d739932ca559/raw/aea5e00d3f23132b22e229fe8ebed53517a0969e/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression rosbag2_cpp rosbag2_storage rosbag2_storage_sqlite3 rosbag2_transport
TEST args: --packages-above rosbag2_compression rosbag2_cpp rosbag2_storage rosbag2_storage_sqlite3 rosbag2_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11172

• Linux
• Linux-aarch64
• Windows

[MichaelOrlov]

I have a concern about not throwing exception in open if we fail to setup read order.

[MichaelOrlov]

Thank you @james-rms. Now LGTM if CI will pass.

[james-rms]

@MichaelOrlov I believe the failures in https://build.ros2.org/job/Rpr__rosbag2__ubuntu_jammy_amd64/431/ are not related to this PR - would you be able to kick off a full CI run on the build farm?

[MichaelOrlov]

@ros-pull-request-builder retest this please

[MichaelOrlov]

Ok re-running full CI since Rpr passed
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11187

• Linux
• Linux-aarch64
• Windows

[MichaelOrlov]

It seems Windows CI build is broken on build farm. I have the same issue in another PR #1175 (comment)
@clalancette Is it known issue?

[clalancette]

@clalancette Is it known issue?

This time of year, the AWS spot prices fluctuate wildly, so our workers sometimes get unceremoniously yanked from underneath us. Just try again; it will eventually work.

[MichaelOrlov]

Re-running Windows build

• Windows

[james-rms]

Gist: https://gist.githubusercontent.com/james-rms/db3e068b715188676e7d53c6ee250379/raw/aea5e00d3f23132b22e229fe8ebed53517a0969e/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp rosbag2_tests
TEST args: --packages-above rosbag2_cpp rosbag2_tests
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11192

• Linux
• Linux-aarch64
• Windows