Don't warn for unknown types if topics are not selected #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
This was referenced Sep 12, 2023
MichaelOrlov
requested review from
gbiggs and
hidmic
and removed request for
a team
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
force-pushed
the
morlov/dont_warn_for_unknown_types_if_not_in_list
branch
from
01e79d6 to
216d70e
Compare
MichaelOrlov
changed the title
clalancette
reviewed
Sep 13, 2023
Rationale: To avoid irrelevant warning messages if topic name hasn't been selected by topic list or regex. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
clalancette
approved these changes
Sep 13, 2023
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/adcb2b4665fb508ad1eb5d0dfcbe33a2/raw/984aaa1ad42a47abc033e08b10fe00857e7085b0/ros2.repos
|
fujitatomoya
approved these changes
Sep 13, 2023
delete-merged-branch
bot
deleted the
morlov/dont_warn_for_unknown_types_if_not_in_list
branch
|
https://github.com/Mergifyio backport iron |
✅ Backports have been created
|
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Don't warn for unknown types if topics are not in the list Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add unit tests to verify regression Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move checks for single type and hidden topics to the bottom Rationale: To avoid irrelevant warning messages if topic name hasn't been selected by topic list or regex. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit bf4038d)
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Don't warn for unknown types if topics are not in the list Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add unit tests to verify regression Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move checks for single type and hidden topics to the bottom Rationale: To avoid irrelevant warning messages if topic name hasn't been selected by topic list or regex. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit bf4038d)
MichaelOrlov
added a commit
that referenced
this pull request
Sep 14, 2023
* Don't warn for unknown types if topics are not in the list Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add unit tests to verify regression Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move checks for single type and hidden topics to the bottom Rationale: To avoid irrelevant warning messages if topic name hasn't been selected by topic list or regex. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit bf4038d) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
added a commit
that referenced
this pull request
Sep 14, 2023
* Don't warn for unknown types if topics are not in the list Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add unit tests to verify regression Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Move checks for single type and hidden topics to the bottom Rationale: To avoid irrelevant warning messages if topic name hasn't been selected by topic list or regex. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit bf4038d) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2023-09-21/33733/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check for the unknown types to the bottom of the checks in the topic_filter