Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Humble] Resolve recording option problem (backport #1649) #1651

Merged
merged 2 commits into from
May 11, 2024
Merged

[Humble] Resolve recording option problem (backport #1649) #1651

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a682ff
Resolve recording option problem (#1649)
Barry-Xu-2018 May 10, 2024
62ce292
Fix cherry-pick conflicts for mergify/bp/humble/pr-1649 (#1652)
Barry-Xu-2018 May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ros2bag/ros2bag/verb/record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def add_arguments(self, parser, cli_name): # noqa: D102
parser.add_argument(
'-e', '--regex', default='',
help='Record only topics containing provided regular expression. '
'Overrides --all, applies on top of topics list.')
'Applies on top of topics list.')
parser.add_argument(
'-x', '--exclude', default='',
help='Exclude topics containing provided regular expression. '
Expand Down Expand Up @@ -168,12 +168,15 @@ def add_arguments(self, parser, cli_name): # noqa: D102

def main(self, *, args): # noqa: D102
# both all and topics cannot be true
if (args.all and (args.topics or args.regex)) or (args.topics and args.regex):
return print_error('Must specify only one option out of topics, --regex or --all')
if (args.all and args.topics):
return print_error('Specify either --all or topics, but not both simultaneously.')
# one out of "all", "topics" and "regex" must be true
if not(args.all or (args.topics and len(args.topics) > 0) or (args.regex)):
return print_error('Invalid choice: Must specify topic(s), --regex or --all')

if args.all and args.regex:
print('[WARN] [ros2bag]: --all will override --regex.')

if args.topics and args.exclude:
return print_error('--exclude argument cannot be used when specifying a list '
'of topics explicitly')
Expand Down
Loading