Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn player into a node #723

Merged
merged 1 commit into from
Apr 9, 2021
Merged

turn player into a node #723

merged 1 commit into from
Apr 9, 2021

Conversation

Karsten1987
Copy link
Collaborator

One step closer to #716.

Turn the player into a node instead of accepting one.

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@Karsten1987 Karsten1987 requested a review from a team as a code owner April 8, 2021 21:57
@Karsten1987 Karsten1987 requested review from mjeronimo and piraka9011 and removed request for a team April 8, 2021 21:57
@Karsten1987
Copy link
Collaborator Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Karsten1987 Karsten1987 merged commit f3f4f10 into master Apr 9, 2021
@Karsten1987 Karsten1987 deleted the kk/player_node branch April 9, 2021 00:16
Kettenhoax pushed a commit to Kettenhoax/rosbag2 that referenced this pull request Apr 9, 2021
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@emersonknapp
Copy link
Collaborator

Related to #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants