cleanup cmakelists #726
Merged
cleanup cmakelists #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
requested review from
mjeronimo and
zmichaels11
and removed request for
a team
|
Karsten1987
force-pushed
the
kk/cleanup_cmake
branch
from
ba21e39
to
97e92d6
Compare
|
build failures to due missing API adaption in #725 CI again:
|
50 tasks
emersonknapp
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Preemptively approving this - assuming the entire change is contained in CMakeLists.txt. Pending the merge of #725, it seems
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Karsten1987
force-pushed
the
kk/cleanup_cmake
branch
from
97e92d6
to
453fff2
Compare
|
I've rebased this branch to be on top of master directly without depending on #725.
if CI turns out green, I'd take @emersonknapp approval to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no new functionality here. I solely cleaned up some copy-paste redundancies in the cmakelists.txt and ordered the tests alphabetically.
sits on top of #725