Design document for keyboard handler #768
Conversation
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
There was a problem hiding this comment.
The way this design sounds - I still am questioning whether this keyboard utility should live in its own repository.
It also makes me wonder whether we should just be pulling in a 3rd party dependency rather than having to maintain code - like SDL or https://github.com/jkuhlmann/gainput
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
…ss event got destructed before keyboard handler. Signed-off-by: Michael Orlov <morlovmr@gmail.com>
… redirected to the file or stream Signed-off-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov
requested review from
Karsten1987 and
zmichaels11
and removed request for
a team
MichaelOrlov
changed the title
…forms and abnormal program termination via Ctrl+C. Signed-off-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov
force-pushed
the
michaelorlov/keyboard_handler_design
branch
from
83ed757
to
14d4a0a
Compare
Though it became pretty big, self contained and independent component with it's own unit tests and design document. It looks like it would be better to have it in a separate package. As regards to the consideration if we should use some third party libraries. I've tried to consider some, but most of them have a big "baggage" in addition and extra other dependencies like https://github.com/jkuhlmann/gainput or not well written/designed and documented. I would prefer to support our own well designed, well written and well documented cross-platform implementation rather than have some dependencies from others and struggle with inability to fix it if some issue will arise. |
|
Closing this PR as would not merge in favor of the newly opened ros-tooling/keyboard_handler#2 |
Design document for keyboard handler package.
Relates to the #735
Part of the #696