check n in resize function

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
ros2 · May 2, 2019 · 308c68c · 308c68c
1 parent 5150096
commit 308c68c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/rosidl_generator_c/src/u16string_functions.c b/rosidl_generator_c/src/u16string_functions.c
@@ -134,6 +134,10 @@ rosidl_generator_c__U16String__resize(
   if (!str) {
     return false;
   }
+  // check valid range of n before allocating n + 1 characters
+  if (n > SIZE_MAX / sizeof(uint16_t) - 1) {
+    return false;
+  }
   uint16_t * data = realloc(str->data, (n + 1) * sizeof(uint16_t));
   if (!data) {
     return false;