Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype code for seeing if FindPython3 is usable for rosidl_python #140

Merged
merged 10 commits into from
Feb 11, 2024
Merged

Prototype code for seeing if FindPython3 is usable for rosidl_python #140

merged 10 commits into from
Feb 11, 2024

Commits on Jan 26, 2024

  1. Prototype code for seeing if FindPython3 is useable for rosidl_python

    @sloretz @clalancette
    sloretz authored and clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d5c14b2 View commit details
    Browse the repository at this point in the history

  2. Add in COMPONENTS keyword. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    07eac31 View commit details
    Browse the repository at this point in the history

  3. Mark the libraries private. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7d11d94 View commit details
    Browse the repository at this point in the history

  4. Fixes for lint_cmake. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    01eee2f View commit details
    Browse the repository at this point in the history

  5. Use Python3::Interpreter in the custom command. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    dd7ccba View commit details
    Browse the repository at this point in the history

  6. Split the finding of Python3 into two stages. 

    In the first stage, we just find the interpreter.  For
the second stage, we use the debug interpreter as
necessary to find NumPy.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a6524b7 View commit details
    Browse the repository at this point in the history

  7. Switch to target_link_libraries almost everywhere. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e8c3449 View commit details
    Browse the repository at this point in the history

  8. Feedback from review. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    62714a1 View commit details
    Browse the repository at this point in the history

  9. More fixes. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4b6622e View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Switch to Python3::Interpreter. 

    python_cmake_module is now only exporting that.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    26ff790 View commit details
    Browse the repository at this point in the history