Add include directories consistently PRIVATE instead of PUBLIC #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps in situations in which:
rosidl_python/rosidl_generator_py/cmake/rosidl_generator_py_generate_interfaces.cmake
Line 174 in 65538f0
This can happen e.g. if you want to cross-compile ROS2 and want to do it on some CICD setups.
The issue is that right now, e.g. for
std_msgs export_std_msgs__rosidl_generator_pyExport.cmake
sets theINTERFACE_INCLUDE_DIRECTORIES
property ofstd_msgs::std_msgs__rosidl_generator_py
to an absolute path (which causes issues if the folder of your numpy installation changes.With this patch all include directories are consistently added
PRIVATE
instead ofPUBLIC
. There shouldn't be a need to expose them anyways.