[backport] Use modern cmake targets to avoid absolute paths to appear in binary … #214
Conversation
…archives (ros2#160) * Use FindPython3 Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> * Make link libraries private when possible to avoid having to export dependencies Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> * Use Python3::Numpy Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
There was a problem hiding this comment.
I have to say that I'm very worried about doing this. I've been poking at this for months in #204 (though that has a different goal), and the whole system here is tricky. For a stable release, I think this is going to be dangerous and may have unwanted side-effects. For those reasons, my opinion is that we should not take this into humble at this time.
@sloretz What's your take on this one?
|
Thank you for the PR, and for your patience! I'm going to close this backport for now because I don't feel confident that it won't break someone's workflow.
I think my main concern is that Python3 CMake module could find a different version of NumPy than the current custom logic in rosidl_generator_py. I think that could break a non-standard Python setup like a venv. While ROS 2 doesn't directly support those, I've seen bugs opened by people using different non-standard Python setups for other platforms. |
…archives (#160)
Use FindPython3
Make link libraries private when possible to avoid having to export dependencies
Use Python3::Numpy