Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp how we check for the correct class. #218

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Revamp how we check for the correct class. #218

merged 2 commits into from
Oct 8, 2024

Commits on Oct 2, 2024

  1. Revamp how we check for the correct class. 

    In an issue it was pointed out that we are decref'ing
before we actually use some of the data, which means that
in theory the garbage collector could reclaim the data
before we used it.  So the original point of this change
was to fix that issue.

However, while looking at it I realized we could slightly
improve performance here by avoiding a copy of the class
and module into a combined string.  Instead, we can compare
them separately, which should reduce the copies.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e184a80 View commit details
    Browse the repository at this point in the history

  2. Fix a warning when building in Release mode. 

    Since the variables are only used in an assert, which
can be compiled out, this could lead to a warning.
Inline the call instead, which should get rid of the warning.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    594aced View commit details
    Browse the repository at this point in the history