Add virtual destructors for WindowManagerInterface and ViewportProjec…

…tionFinder (#356) To fix the following warnings (converted to errors by compile options): error: destructor called on non-final 'MockProjectionFinder' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor] error: destructor called on non-final 'MockWindowManagerInterface' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
ros2 · Oct 8, 2018 · 9eb7964 · 9eb7964
1 parent e5a0fc8
commit 9eb7964
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/rviz_common/include/rviz_common/window_manager_interface.hpp b/rviz_common/include/rviz_common/window_manager_interface.hpp
@@ -49,6 +49,8 @@ class PanelDockWidget;
 class WindowManagerInterface
 {
 public:
+  virtual ~WindowManagerInterface() = default;
+
   /// Return the parent QWidget.
   virtual
   QWidget *

diff --git a/rviz_rendering/include/rviz_rendering/viewport_projection_finder.hpp b/rviz_rendering/include/rviz_rendering/viewport_projection_finder.hpp
@@ -52,6 +52,7 @@ class RVIZ_RENDERING_PUBLIC ViewportProjectionFinder
 {
 public:
   ViewportProjectionFinder() = default;
+  virtual ~ViewportProjectionFinder() = default;
 
   virtual std::pair<bool, Ogre::Vector3> getViewportPointProjectionOnXYPlane(
     RenderWindow * render_window, int x, int y);