Migrate scalar displays (#367)

* moved scalar displays (temperature, illuminance, relative humidity, fluid pressure) header and source file from rviz to rviz2 * Changed header and source files to compile successfully changed pointers to smart pointers replaced outdated headers updated CMakeList and plgins_description * Refactored Scalar Displays Added the header file point cloud scalar that includes all functionality that was possible to template. This excludes the process message function and the set initial values und update properties function. Furthermore the process message function was split up into several smaller functions where the createpointcloud2message function allows for unit tests because no instance of the actual point cloud is needed. * Update Docs updated ported displays. Changed ament for colcon * Implemented Visual Tests They test if color changes correctly. Refactored point cloud common page object by implementing the queuesize method. Therefore laser scan, point cloud and point cloud 2 page objects become redundant * Implemented point cloud scalar display test Test for correct memory allocation and correct copy of values. Also uncrustified files with linter errors * Pull Request Changes Indentation, doc blocks * Added DBUILD_TESTING keyword without it the tests do not execute * added DBUILD_TESTING keyword without it the tests do not run
ros2 · Jan 7, 2019 · 9f3f3a6 · 9f3f3a6
1 parent 2077b3a
commit 9f3f3a6
Show file tree

Hide file tree

Showing 45 changed files with 1,534 additions and 978 deletions.
diff --git a/README.md b/README.md
@@ -15,12 +15,14 @@ For some displays, the [documentation is updated](docs/FEATURES.md).
 | Displays              | Tools         | View Controller       | Panels          |
 | --------------------- | ------------- | --------------------- | --------------- |
 | Camera                | Move Camera   | Orbit                 | Displays        |
-| Grid                  | Focus Camera  | XY Orbit              | Help            |
-| Grid Cells            | Measure       | First Person          | Selections      |
-| Image                 | Select        | Third Person Follower | Tool Properties |
-| Laser Scan            | 2D Nav Goal   | Top Down Orthographic | Views           |
-| Map                   | Publish Point |                       |                 |
-| Marker                | Initial Pose  |
+| Fluid Pressure        | Focus Camera  | XY Orbit              | Help            |
+| Grid                  | Measure       | First Person          | Selections      |
+| Grid Cells            | Select        | Third Person Follower | Tool Properties | 
+| Illuminance           | 2D Nav Goal   | Top Down Orthographic | Views           |
+| Image                 | Publish Point |
+| Laser Scan            | Initial Pose  |
+| Map                   | 
+| Marker                | 
 | Marker Array          |
 | Odometry              |
 | Point Cloud (1 and 2) |
@@ -29,9 +31,12 @@ For some displays, the [documentation is updated](docs/FEATURES.md).
 | Pose                  |
 | Pose Array            |
 | Range                 |
+| Relative Humidity     |
 | Robot Model           |
+| Temperature           |
 | TF                    |
 
+
 ### Not yet ported
 These features have not been ported to `ros2/rviz` yet.
 
@@ -40,13 +45,9 @@ These features have not been ported to `ros2/rviz` yet.
 | Axes                 | Interact     | Time   |
 | DepthCloud           |
 | Effort               |
-| Fluid Pressure       |
-| Illuminance          |
 | Interactive Marker   |
 | Oculus               |
 | Pose With Covariance |
-| Relative Humidity    |
-| Temperature          |
 | Wrench               |
 
 Other features:

diff --git a/rviz/src/rviz/default_plugin/fluid_pressure_display.cpp b/rviz/src/rviz/default_plugin/fluid_pressure_display.cpp
diff --git a/rviz/src/rviz/default_plugin/illuminance_display.cpp b/rviz/src/rviz/default_plugin/illuminance_display.cpp