Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append measured subscription frequency to topic status #1113

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Append measured subscription frequency to topic status #1113

merged 1 commit into from
Dec 28, 2023

Conversation

Yadunund
Copy link
Member

Addresses #1112

image

@Yadunund Yadunund requested a review from ahcorde as a code owner December 27, 2023 02:28
@Yadunund Yadunund mentioned this pull request Dec 27, 2023
Closed
@yang19900808
Copy link

@Yadunund
Good job buddy, I also implement this method as shown in the following picture.
lQLPJw3NPBARtxPNAV3NAhSwCtq8inB2w2QFfBiznHMaAA_532_349

Will this feature be integrated into future version?

ahcorde
ahcorde requested changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncrustify is failing https://build.ros2.org/job/Rpr__rviz__ubuntu_jammy_amd64/356/testReport/junit/(root)/projectroot/uncrustify/

@Yadunund
Append measured subscription frequency to topic status
0f63b63 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund force-pushed the yadu/topic_frequency branch from de6b4c2 to 0f63b63 Compare December 27, 2023 07:47
@Yadunund
Copy link
Member Author

@ahcorde fixed!

ahcorde
ahcorde approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 68d9167 into rolling Dec 28, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the yadu/topic_frequency branch December 28, 2023 10:12
@ahcorde
Copy link
Contributor

ahcorde commented Jan 25, 2024

https://github.com/Mergifyio backport humble iron

@mergify Mergify
Copy link

mergify bot commented Jan 25, 2024 •
edited
Loading

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 25, 2024
@Yadunund @mergify
Append measured subscription frequency to topic status (#1113)
687a4ca 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
(cherry picked from commit 68d9167)
mergify bot pushed a commit that referenced this pull request Jan 25, 2024
@Yadunund @mergify
Append measured subscription frequency to topic status (#1113)
4671bd4 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
(cherry picked from commit 68d9167)
This was referenced Jan 25, 2024
Merged
Merged
ahcorde pushed a commit that referenced this pull request Jan 25, 2024
@mergify @Yadunund
Append measured subscription frequency to topic status (#1113) (#1129)
7755f13 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
(cherry picked from commit 68d9167)

Co-authored-by: Yadu <yadunund@openrobotics.org>
ahcorde pushed a commit that referenced this pull request Jan 25, 2024
@mergify @Yadunund
Append measured subscription frequency to topic status (#1113) (#1130)
a551718 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
(cherry picked from commit 68d9167)

Co-authored-by: Yadu <yadunund@openrobotics.org>
@Yadunund Yadunund mentioned this pull request Feb 21, 2024
Closed
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-jazzy-jalisco-released/37862/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yadunund @yang19900808 @ahcorde @ros-discourse