Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qt dependency to testing packages. #330

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

nuclearsandwich
Copy link
Member

The binarydeb builds for these packages are currently failing to configure

05:09:46 CMake Error at CMakeLists.txt:26 (find_package):
05:09:46   By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
05:09:46   asked CMake to find a package configuration file provided by "Qt5", but
05:09:46   CMake did not find one.
05:09:46 
05:09:46   Could not find a package configuration file provided by "Qt5" with any of
05:09:46   the following names:
05:09:46 
05:09:46     Qt5Config.cmake
05:09:46     qt5-config.cmake
05:09:46 
05:09:46   Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
05:09:46   to a directory containing one of the above files.  If "Qt5" provides a
05:09:46   separate development package or SDK, be sure it has been installed.
05:09:46 
05:09:46 
05:09:46 -- Configuring incomplete, errors occurred!

The example above was excerpted from this build of rviz_rendering_tests.

rviz_visual_testing_framework actually gets this dependency satisfied by the build_export_depend in rviz_common so we could take that out. I'm not sure if there's a preference to depend directly on any package that's used directly or not.

@nuclearsandwich nuclearsandwich added the in review Waiting for review (Kanban column) label Jun 28, 2018
@nuclearsandwich nuclearsandwich self-assigned this Jun 28, 2018
@nuclearsandwich nuclearsandwich requested a review from wjwwood June 28, 2018 13:30
@nuclearsandwich nuclearsandwich added this to the bouncy milestone Jun 28, 2018
@wjwwood wjwwood merged commit b0f7c11 into ros2 Jun 28, 2018
@wjwwood wjwwood deleted the qt5-build-dep-in-test-packages branch June 28, 2018 17:44
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants