Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add virtual destructors for WindowManagerInterface and ViewportProjectionFinder #356

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add virtual destructors for WindowManagerInterface and ViewportProjectionFinder #356

merged 1 commit into from
Oct 8, 2018

Commits on Oct 6, 2018

  1. Add virtual destructors for WindowManagerInterface and ViewportProjec… 

    …tionFinder

To fix the following warnings (converted to errors by compile options):
error: destructor called on non-final 'MockProjectionFinder' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
error: destructor called on non-final 'MockWindowManagerInterface' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    @kartikmohta
    kartikmohta committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    531d080 View commit details
    Browse the repository at this point in the history