fix deprecation warnings with new Qt #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodall <william@osrfoundation.org>
Karsten1987
approved these changes
Jul 31, 2019
|
CI on the newly updated macOS machine: |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
New CI after @jacobperron and I "fixed" a segfault 😐: |
Karsten1987
reviewed
Aug 1, 2019
wjwwood
added a commit
that referenced
this pull request
Aug 1, 2019
* fix deprecation warnings with new Qt Signed-off-by: William Woodall <william@osrfoundation.org> * Get QScreen from main window always Signed-off-by: Jacob Perron <jacob@openrobotics.org>
wjwwood
added a commit
that referenced
this pull request
Aug 1, 2019
I didn't catch this because I've been glued to the project board over my own GitHub notifications. I added this to the board for Patch 3 but rviz is high enough in the stack that we can still pull this for patch 2 if we do it before the end of the day today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compiler warnings after upgrading to the new Qt on our macOS machines:
https://ci.ros2.org/view/All/job/test_packaging_osx/1/warnings11Result/
I think we should also backport this for dashing, but we could choose to wait for the next patch release if we're ok ignoring these warnings. @nuclearsandwich do you have an opinion?