Remove ROS arguments before passing to QApplication

[jacobperron]

Resolves #442

[jacobperron]

• Linux
• Linux-aarch64
• macOS
• Windows

[dirk-thomas]

In ROS 1 the init(int argc, char ** argv) function not only used the ROS specific arguments but also updated the arguments to leave only the non-ROS arguments. I think a similar function would be very helpful to avoid the overhead from this PR.

[wjwwood]

lgtm, thanks for tackling it Jacob.

[jacobperron]

In ROS 1 the init(int argc, char ** argv) function not only used the ROS specific arguments but also updated the arguments to leave only the non-ROS arguments. I think a similar function would be very helpful to avoid the overhead from this PR.

Sounds reasonable to me. But we should be careful in this case, since we still want to pass the argv containing ROS arguments later in main:

rviz/rviz2/src/main.cpp

Line 75 in 265dbb3

if (vapp.init(argc, argv)) {

[wjwwood]

Also see: ros2/rcl#219