Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainer to point to ros-security mailing list + fix package.xml #179

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

mikaelarguedas
Copy link
Member

No description provided.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@kyrofa
Copy link
Member

kyrofa commented Mar 19, 2020

(note to observers that we're waiting for #178 to be merged so we can rebase here and get some light tests run).

@kyrofa
Copy link
Member

kyrofa commented Mar 25, 2020

@mikaelarguedas given that we're holding off on #178 for a little more investigation, shall we run build farm tests here and land?

@mikaelarguedas
Copy link
Member Author

Sure, CI just for sros2 and sros2_cmake

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas merged commit a667027 into ros2:master Mar 26, 2020
@mikaelarguedas mikaelarguedas deleted the ros-security-maintainer branch March 26, 2020 16:02
@mikaelarguedas
Copy link
Member Author

@ivanpauno apologies this is apparently conflicting with #177

Hopefully not too big of a pain during your overall commit cleanup of that PR. If it is happy to revert this the time you get it merge.

mikaelarguedas added a commit to mikaelarguedas/sros2 that referenced this pull request Jun 5, 2020
….xml (ros2#179)

* update maintainer and fix invalid package.xml

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* use format 3 for consistency and futureproofness

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
mikaelarguedas added a commit that referenced this pull request Jun 5, 2020
….xml (#179)

* update maintainer and fix invalid package.xml

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* use format 3 for consistency and futureproofness

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas added a commit to mikaelarguedas/sros2 that referenced this pull request Jun 16, 2020
….xml (ros2#179)

* update maintainer and fix invalid package.xml

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

* use format 3 for consistency and futureproofness

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants