Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use test_msgs instead of std_{msgs,srvs} packages for testing #181

Merged
merged 1 commit into from
Mar 30, 2020
Merged

use test_msgs instead of std_{msgs,srvs} packages for testing #181

merged 1 commit into from
Mar 30, 2020

Conversation

mikaelarguedas
Copy link
Member

as this is the raison-d'etre of the test_msgs package and will save non-negligible build time to avoid building those packages.

E.g. from https://ci.ros2.org/job/ci_osx/7955/console

Finished <<< std_msgs [14min 37s]

@mikaelarguedas
use test_msgs instead of std message packages
1ba4a0b 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
kyrofa
kyrofa approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I... didn't know that existed 😊 . Thank you!

@kyrofa kyrofa requested a review from artivis March 26, 2020 16:08
@artivis
Copy link

artivis commented Mar 26, 2020

Didn't know either about test_msgs, thanks for the explanations @mikaelarguedas.

@kyrofa
Copy link
Member

kyrofa commented Mar 26, 2020 •
edited by mikaelarguedas
Loading

CI for sros2:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: another run on MacOS came back green...some flakyness is present

  • macOS Build Status

@kyrofa kyrofa merged commit 547e2c2 into ros2:master Mar 30, 2020
@mikaelarguedas mikaelarguedas deleted the use_test_msgs branch March 31, 2020 06:43
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrofa kyrofa kyrofa approved these changes

@artivis artivis artivis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelarguedas @artivis @kyrofa