Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: reorganize key API #192

Merged
merged 4 commits into from
Apr 8, 2020
Merged

api: reorganize key API #192

merged 4 commits into from
Apr 8, 2020

Conversation

kyrofa
Copy link
Member

@kyrofa kyrofa commented Apr 7, 2020

This PR continues the reorganization of #188 by extracting the key API into its own module.

Note that this introduces no behavioral changes, it's just moving code around.

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #192 into master will increase coverage by 0.22%.
The diff coverage is 87.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   55.15%   55.38%   +0.22%     
==========================================
  Files          16       17       +1     
  Lines         582      585       +3     
  Branches       52       52              
==========================================
+ Hits          321      324       +3     
  Misses        247      247              
  Partials       14       14              
Flag Coverage Δ
#unittests 55.38% <87.34%> (+0.22%) ⬆️
Impacted Files Coverage Δ
sros2/sros2/api/__init__.py 32.69% <50.00%> (-32.31%) ⬇️
sros2/sros2/verb/list_keys.py 78.94% <50.00%> (ø)
sros2/sros2/api/_key.py 90.14% <90.14%> (ø)
sros2/sros2/verb/create_key.py 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d856a...5b05fce. Read the comment docs.

Copy link
Member

@ruffsl ruffsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick, but LGTM! Thanks @kyrofa !

@kyrofa kyrofa requested a review from artivis April 8, 2020 04:02
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@artivis artivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kyrofa kyrofa merged commit 1b41a2a into ros2:master Apr 8, 2020
@kyrofa kyrofa deleted the feature/api-clean-key branch April 8, 2020 15:03
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants