-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: reorganize key API #192
Conversation
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 55.15% 55.38% +0.22%
==========================================
Files 16 17 +1
Lines 582 585 +3
Branches 52 52
==========================================
+ Hits 321 324 +3
Misses 247 247
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nitpick, but LGTM! Thanks @kyrofa !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR continues the reorganization of #188 by extracting the key API into its own module.
Note that this introduces no behavioral changes, it's just moving code around.