Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove function leftover from old generation strategy #207

Merged

Conversation

mikaelarguedas
Copy link
Member

This function is unused since the migration to lxml to manage permissions and policies #72

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #207 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   77.52%   77.75%   +0.23%     
==========================================
  Files          16       16              
  Lines         574      571       -3     
  Branches       53       52       -1     
==========================================
- Hits          445      444       -1     
+ Misses        109      107       -2     
  Partials       20       20              
Flag Coverage Δ
#unittests 77.75% <ø> (+0.23%) ⬆️
Impacted Files Coverage Δ
sros2/sros2/verb/generate_policy.py 87.96% <ø> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb0f71...71b6021. Read the comment docs.

@mikaelarguedas
Copy link
Member Author

@ros2/security-reviewers heads-up I'm planning on merging this today, please consider submitting your reviews in the next couple hours.

@mikaelarguedas mikaelarguedas merged commit 2ba1b05 into ros2:master May 4, 2020
@mikaelarguedas mikaelarguedas deleted the remove_unused_format_topics branch May 4, 2020 21:10
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants