Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nightly image including all 3 RMWs #215

Merged
merged 2 commits into from
May 15, 2020

Conversation

mikaelarguedas
Copy link
Member

This will unlock PRs adding tests for multiple RMW implementations such as #214

For now no test expect security DDS plugins to be installed. If that becomes the case we would need to either blacklist connext or find a way for the tests to fetch a license with security support and install the security plugins.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible, although would you mind adding a "this doesn't include connext security plugins" as a comment in the YAML so we don't lose that tidbit?

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files          16       16           
  Lines         576      576           
  Branches       52       52           
=======================================
  Hits          449      449           
  Misses        107      107           
  Partials       20       20           
Flag Coverage Δ
#unittests 77.95% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e08d8...f752a73. Read the comment docs.

…er images

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
Copy link
Member Author

"this doesn't include connext security plugins" as a comment in the YAML so we don't lose that tidbit?

Sure thing, added it in f752a73 for both jobs

@kyrofa
Copy link
Member

kyrofa commented May 15, 2020

Thank you!

@mikaelarguedas mikaelarguedas merged commit 2399abf into ros2:master May 15, 2020
@mikaelarguedas mikaelarguedas deleted the rmw-nonfree branch May 15, 2020 17:05
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants