-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change rmw_connext_cpp -> rmw_connextdds. #255
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
should be merged after ros2/ros2#1116 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a follow up to #253
@SidFaber @mikaelarguedas A second review here would be appreciated (it is only changes to the documentation, so should be minor). Thanks in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
CI for this was in ros2/rmw_connextdds#9 (comment) (the yellow builds were because of an uncrustify failure in rclcpp that has since been fixed). So I'll go ahead and merge this, thanks everyone for the reviews. |
Signed-off-by: Chris Lalancette clalancette@openrobotics.org