Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rmw_connext_cpp -> rmw_connextdds. #255

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

clalancette
Copy link
Contributor

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #255 (82575b1) into master (a02492f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   77.25%   77.25%           
=======================================
  Files          25       25           
  Lines         664      664           
  Branches       55       55           
=======================================
  Hits          513      513           
  Misses        131      131           
  Partials       20       20           
Flag Coverage Δ
unittests 77.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...wp79c/sros2/sros2/sros2/policy/schemas/__init__.py
.../sros2/sros2/sros2/policy/defaults/dds/__init__.py
...o8wwp79c/sros2/sros2/sros2/keystore/_permission.py
...c/dz5o8wwp79c/sros2/sros2/sros2/policy/__init__.py
...c/sros2/sros2/sros2/policy/schemas/dds/__init__.py
...dz5o8wwp79c/sros2/sros2/sros2/keystore/_enclave.py
...dz5o8wwp79c/sros2/sros2/sros2/keystore/__init__.py
...s/src/dz5o8wwp79c/sros2/sros2/sros2/api/_policy.py
ros_ws/src/dz5o8wwp79c/sros2/sros2/setup.py
.../dz5o8wwp79c/sros2/sros2/sros2/command/security.py
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02492f...82575b1. Read the comment docs.

@ivanpauno
Copy link
Member

should be merged after ros2/ros2#1116

Copy link
Contributor

@asorbini asorbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a follow up to #253

@clalancette
Copy link
Contributor Author

@SidFaber @mikaelarguedas A second review here would be appreciated (it is only changes to the documentation, so should be minor). Thanks in advance.

Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@clalancette
Copy link
Contributor Author

CI for this was in ros2/rmw_connextdds#9 (comment) (the yellow builds were because of an uncrustify failure in rclcpp that has since been fixed). So I'll go ahead and merge this, thanks everyone for the reviews.

@clalancette clalancette merged commit 02c141d into master Mar 25, 2021
@clalancette clalancette deleted the clalancette/remove-rmw-connext-references branch March 25, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants