-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros2 service crystal #71
Merged
Merged
Commits on Nov 28, 2018
-
Add generate permissions security command line
Generate an sros2 yaml permissions file with the permissions of every visible node on the dds network. Add custom service security to sros2 Example: run the minimal_publisher_lambda node Execute: `ros2 security generate_permissions node_policies.yaml` It will create the following file in the current directory: ``` /minimal_publisher: services: /minimal_publisher/describe_parameters: allows: - request - reply . . . topics: /parameter_events: allows: - publish - subscribe /topic: allows: - publish ``` cr https://code.amazon.com/reviews/CR-3943967
Configuration menu - View commit details
-
Copy full SHA for 3d7cda1 - Browse repository at this point
Copy the full SHA 3d7cda1View commit details -
Proposed policy definition changes
Issue: services and actions are not considered in the policy yaml definition. Solution: Add ipc types (services and actions) Issue: access values are strings with p, s, or ps in order. This is not descriptive and difficult to scale should more permissions become necessary. Solution: Either change the parsing of the string or change the yaml to be more flexible and descriptive for users. The proposed changes include: * Access value is a list, not a string * Add ipc types such as actions and services * Access values are no longer shorthand p or s, but publish/subscribe Amend policy definition with verbose ROS ipc types
Configuration menu - View commit details
-
Copy full SHA for 7b7de3d - Browse repository at this point
Copy the full SHA 7b7de3dView commit details -
Add security macro for automagically generating public and private keys for authentication and encryption. custom macro use `ros2_secure_node(NODES node_name_1 node_name_2 ...)` cr https://code.amazon.com/reviews/CR-3517594
Configuration menu - View commit details
-
Copy full SHA for 597f1bd - Browse repository at this point
Copy the full SHA 597f1bdView commit details
Commits on Jan 9, 2019
-
Addresses comments from pull-71
* Adds check to allow "/" or no "/" in permissions file * Renames policy definition file to markdown
Configuration menu - View commit details
-
Copy full SHA for 3c4f981 - Browse repository at this point
Copy the full SHA 3c4f981View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81189cf - Browse repository at this point
Copy the full SHA 81189cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3d9de2 - Browse repository at this point
Copy the full SHA a3d9de2View commit details
Commits on Jan 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7a67e2f - Browse repository at this point
Copy the full SHA 7a67e2fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.