Sros2 cmake macros #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables addition of new colcon built packages in this repo
|
Depends on #74 |
|
These changes split from the original PR #71 and has all changes requested for the cmake macro from that review |
|
mjcarroll
approved these changes
Jan 15, 2019
jacobperron
reviewed
Jan 15, 2019
| endif() | ||
| find_program(PROGRAM ros2) | ||
| if (NOT PROGRAM) | ||
| message("Unable to find ros2cli, have you sourced your ros setup files?") |
There was a problem hiding this comment.
We should add ros2cli as a build and build_export dependency to the package.xml so we don't have to rely on sourcing a setup file in the case that we're building alongside ros2cli.
ruffsl
reviewed
Jan 15, 2019
ruffsl
reviewed
Jan 15, 2019
|
@ross-desmond Just as a housekeeping note, we're moving forward on making a release for the patch, and this will get in the first sync after the patch release. |
Additionally update build dependencies.
|
Awesome, making changes... |
|
Disregard that CI, I think I used the wrong repos file... |
Looks like all changes are accounted for. |
|
CI up to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cmake macros for generating keys and keystore for nodes at compile time.