Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing array longers than 101 #216

Merged
merged 1 commit into from
Aug 10, 2017
Merged

testing array longers than 101 #216

merged 1 commit into from
Aug 10, 2017

Conversation

mikaelarguedas
Copy link
Member

This is mostly to make sure that we don't rely on the magic 101 here or any other arbitrary limitation on arrays

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Aug 10, 2017
dirk-thomas
dirk-thomas approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can the weird constant be removed from rmw_fastrtps?

@mikaelarguedas
Copy link
Member Author

@allenh1 is currently looking at ros2/rmw_fastrtps#72.
Now that the fixtures here don't assume 257 for max string length and 101 for max array size we should be able to remove both from rmw_fastrtps.

@mikaelarguedas mikaelarguedas merged commit 21cc532 into master Aug 10, 2017
@mikaelarguedas mikaelarguedas deleted the longer_arrays branch August 10, 2017 19:12
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @dirk-thomas