Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new security files including governance fix #264

Merged
merged 1 commit into from
Apr 26, 2018
Merged

new security files including governance fix #264

merged 1 commit into from
Apr 26, 2018

Conversation

mikaelarguedas
Copy link
Member

connects to ros2/sros2#44

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas
new security files including governance fix
aa62a8e 
provide wide domain id range to work on all ci machines
@mikaelarguedas mikaelarguedas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 25, 2018
@mikaelarguedas mikaelarguedas self-assigned this Apr 25, 2018
@mikaelarguedas mikaelarguedas mentioned this pull request Apr 25, 2018
Merged
wjwwood
wjwwood reviewed Apr 25, 2018
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel I am qualified to review this... I'd say +1 so long as you tested it.

@mikaelarguedas
Copy link
Member Author

The only noticeable changes here are

This PR is to confirm that files generated once ros2/sros2#44 is merged are still working as expected.

The rest of the diff really is just garbage from regenerating certificate and keys and is not reviewable...

Thanks for the reviews on both PRs!

@mikaelarguedas mikaelarguedas merged commit c4bf2a6 into master Apr 26, 2018
@mikaelarguedas mikaelarguedas deleted the new_governance_files branch April 26, 2018 01:45
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood left review comments

Assignees

@mikaelarguedas mikaelarguedas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @wjwwood