Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor corrected depth check for prefix in parameter_fixtures.hpp #529

Merged
merged 1 commit into from
Sep 18, 2023
Merged

refactor corrected depth check for prefix in parameter_fixtures.hpp #529

merged 1 commit into from
Sep 18, 2023

Conversation

leeminju531
Copy link
Contributor

This refactor depends on ros2/rclcpp#2300

@leeminju531
refactor corrected depth check for prefix in parameter_fixtures.hpp
db58b0b 
Signed-off-by: leeminju531 <dlalswn531@naver.com>
@leeminju531 leeminju531 mentioned this pull request Sep 15, 2023
Merged
clalancette
clalancette approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this seems correct to me.

@fujitatomoya
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 6b89236 into ros2:rolling Sep 18, 2023
2 checks passed
@leeminju531 leeminju531 deleted the leeminju531/test-refactor branch September 19, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@methylDragon methylDragon Awaiting requested review from methylDragon methylDragon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leeminju531 @fujitatomoya @clalancette