Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build shared lib only if BUILD_SHARED_LIBS is set #34

Merged
merged 2 commits into from
Jul 12, 2022
Merged

build shared lib only if BUILD_SHARED_LIBS is set #34

merged 2 commits into from
Jul 12, 2022

Conversation

hannes09
Copy link
Contributor

with this change yaml_cpp_vendor also build as a static lib if BUILD_SHARED_LIBS=OFF

build shared lib only if BUILD_SHARED_LIBS is set
68cd787 
Signed-off-by: Hannes Harms <h.harms@grimme.de>
@methylDragon
Copy link

methylDragon commented Jun 9, 2022 •
edited
Loading

Hi there! With the merge of ament/ament_cmake#390 , we can now merge this, with one change.
Could you help to add this line here, please? Once you do I'll launch CI and work towards getting this merged!

find_package(ament_cmake REQUIRED)
ament_add_default_options() <<<--- THIS ONE! ⭐

@methylDragon methylDragon self-requested a review June 9, 2022 21:42
methylDragon
methylDragon requested changes Jun 13, 2022
View reviewed changes
Copy link

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above post

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:26
@methylDragon
Copy link

Bumping @hannes09

use ament_add_default_options to allow for explicit invocation for co…
380320c 
…mmon options

Signed-off-by: Hannes Harms <h.harms@grimme.de>
@hannes09
Copy link
Contributor Author

I have added ament_add_default_options, but now the build fails.

@methylDragon
Copy link

@ros-pull-request-builder retest this please

@methylDragon methylDragon merged commit 16f9d25 into ros2:rolling Jul 12, 2022
@methylDragon
Copy link

methylDragon commented Jul 12, 2022 •
edited
Loading

I forgot ci ..

my bad

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

Assignees

@methylDragon methylDragon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannes09 @methylDragon