Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bubble-chart-legend #786

Open
roschaefer opened this issue Aug 29, 2018 · 3 comments
Open

Refactor bubble-chart-legend #786

roschaefer opened this issue Aug 29, 2018 · 3 comments

Comments

@roschaefer
Copy link
Owner

After discovering how to import 3rd party libraries for d3 and installing d3-svg-legend we definitely should refactor bubble-chart-legend component to use that plugin.

@mattwr18
Copy link
Collaborator

mattwr18 commented Oct 3, 2018

@roschaefer says: for later reference

it would be great to refactor the chart next to the bubble chart visualization

#786
this whole component:
https://github.com/roschaefer/rundfunk-mitbestimmen/blob/master/frontend/app/components/visualize/bubble-chart-legend.js
can be replaced with sth similar to:
https://github.com/roschaefer/rundfunk-mitbestimmen/blob/master/frontend/app/components/visualize/graph/graph-visualization.js#L48

@mattwr18
Copy link
Collaborator

mattwr18 commented Oct 3, 2018

for creating seed data that is from more than three months in the past:
https://en.wikipedia.org/wiki/Slowly_changing_dimension#Type_4
Also, have a look at these:
https://github.com/ifad/chronomodel
https://github.com/ifad/chronomodel/blob/master/spec/support/helpers.rb
tests using time travel:

@mattwr18
Copy link
Collaborator

mattwr18 commented Oct 3, 2018

This is the link to the d3-legend from susie lu with examples:
https://d3-legend.susielu.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants