Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve whitespace and search matches colors #4

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

Iorvethe
Copy link
Contributor

@Iorvethe Iorvethe commented Apr 7, 2023

Whitespaces

Before After
image image

Search matches

Before After
image image

Closes #3

@Iorvethe Iorvethe changed the title Whitespace and search matches Improve whitespace and search matches Apr 7, 2023
@Iorvethe Iorvethe changed the title Improve whitespace and search matches Improve whitespace and search matches colors Apr 7, 2023
@mvllow
Copy link
Member

mvllow commented Apr 7, 2023

I love the search change, I thought something looked off when switching between neovim and helix. What if we meet in the middle for the whitespace, maybe highlight_high? Seeing how this is an opt-in feature, more contrast via muted is fine if you feel it's needed :)

@Iorvethe
Copy link
Contributor Author

Iorvethe commented Apr 8, 2023

You are right, the highlight_high is better, since these are way less important than comments and shouldn’t be with the same colors.

As for the search, happy that you like it! Now that I used it a little, I’m thinking of maybe adding an indicator of which line the cursor is on, because it becomes tiresome to always look at the left side to know which result is selected. Especially with long paths spanning half the editor.

What kind of highlight would in you opinion be better suited here? The default theme changes the foreground but other themes appear to be fiddling with the background.

@mvllow
Copy link
Member

mvllow commented Apr 8, 2023

For the current search line background we use overlay in other apps :)

@Iorvethe
Copy link
Contributor Author

Iorvethe commented Apr 9, 2023

Okay, added the ovelay. It should be good now!

@mvllow mvllow merged commit bf3c652 into rose-pine:main Apr 10, 2023
mvllow pushed a commit to mvllow/helix that referenced this pull request Apr 10, 2023
* feat: make whitespace characters more readable

* feat: make search matches more discernable

* fix: reduce importance of whitespace characters

* feat: add background to ui.text.focus

rose-pine/helix#4
archseer pushed a commit to helix-editor/helix that referenced this pull request Apr 10, 2023
* feat: make whitespace characters more readable

* feat: make search matches more discernable

* fix: reduce importance of whitespace characters

* feat: add background to ui.text.focus

rose-pine/helix#4

Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
…-editor#6679)

* feat: make whitespace characters more readable

* feat: make search matches more discernable

* fix: reduce importance of whitespace characters

* feat: add background to ui.text.focus

rose-pine/helix#4

Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
…-editor#6679)

* feat: make whitespace characters more readable

* feat: make search matches more discernable

* fix: reduce importance of whitespace characters

* feat: add background to ui.text.focus

rose-pine/helix#4

Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
…-editor#6679)

* feat: make whitespace characters more readable

* feat: make search matches more discernable

* fix: reduce importance of whitespace characters

* feat: add background to ui.text.focus

rose-pine/helix#4

Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace characters barely visible
2 participants