-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve whitespace and search matches colors #4
Improve whitespace and search matches colors #4
Conversation
I love the search change, I thought something looked off when switching between neovim and helix. What if we meet in the middle for the whitespace, maybe |
You are right, the As for the search, happy that you like it! Now that I used it a little, I’m thinking of maybe adding an indicator of which line the cursor is on, because it becomes tiresome to always look at the left side to know which result is selected. Especially with long paths spanning half the editor. What kind of highlight would in you opinion be better suited here? The default theme changes the foreground but other themes appear to be fiddling with the background. |
For the current search line background we use |
Okay, added the |
* feat: make whitespace characters more readable * feat: make search matches more discernable * fix: reduce importance of whitespace characters * feat: add background to ui.text.focus rose-pine/helix#4
* feat: make whitespace characters more readable * feat: make search matches more discernable * fix: reduce importance of whitespace characters * feat: add background to ui.text.focus rose-pine/helix#4 Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
…-editor#6679) * feat: make whitespace characters more readable * feat: make search matches more discernable * fix: reduce importance of whitespace characters * feat: add background to ui.text.focus rose-pine/helix#4 Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
…-editor#6679) * feat: make whitespace characters more readable * feat: make search matches more discernable * fix: reduce importance of whitespace characters * feat: add background to ui.text.focus rose-pine/helix#4 Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
…-editor#6679) * feat: make whitespace characters more readable * feat: make search matches more discernable * fix: reduce importance of whitespace characters * feat: add background to ui.text.focus rose-pine/helix#4 Co-authored-by: Iorvethe <58810330+Iorvethe@users.noreply.github.com>
Whitespaces
Search matches
Closes #3