Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media to be used on README #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

media to be used on README #74

wants to merge 1 commit into from

Conversation

amysea123
Copy link

Some pictures and a short GAZEBO video to add visual context to README

Copy link
Contributor

@JMoore5353 JMoore5353 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. It looks like the default gains with the ROSplane controller aren't tuned super tightly in this run, so the plane is following a wobbly path. I can work with you to tune the controller a bit so we can get a smoother-looking path for this image. We may want to add a legend to the image as well.

Copy link
Contributor

@JMoore5353 JMoore5353 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thanks for doing this! Could you also add the images to the README file before we merge it in? In addition to the pictures in the README, I think it would be good to add some blurbs about what each of the images is about.

I also saw this article about embedding a YouTube video in Markdown into the README. This might be better than uploading the video to GitHub (to save space). Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants