improvement of InformalNormalizer #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imani
requested changes
Mar 7, 2022
Code/TurnSemiSpaceFileToSpaceFile.py
Outdated
Comment on lines
1
to
20
| # sourceFileAddress = "./output-test-formal.txt" | ||
| # destinationFileAddress = "./output-test-formal-space.txt" | ||
| sourceFileAddress = "./shekasteh-test.tok.formal" | ||
| destinationFileAddress = "./shekasteh-test-space.tok.formal" | ||
|
|
||
| def main(sourceAddress,destinationAddress): | ||
| with open(sourceAddress, "r", encoding='utf-8') as readFile, open(destinationAddress, "w", encoding='utf-8') as writeFile: | ||
| while True: | ||
| line = readFile.readline().strip() | ||
| if not line: | ||
| break | ||
| line = line.replace('', ' ') | ||
| line = line.replace('', ' ') | ||
| line = line.replace('.', '') | ||
| line = line.replace('؟', '') | ||
| line = line.replace('!', '') | ||
| writeFile.write(line + "\n") | ||
|
|
||
|
|
||
| main(sourceFileAddress,destinationFileAddress) |
There was a problem hiding this comment.
This file is not necessary to include in the repository.
Code/output-dev-broken.txt
Outdated
| @@ -0,0 +1,917 @@ | |||
| . باید جدا بشویم تا فضای بیشتری رو بتوانیم چک کنیم | |||
There was a problem hiding this comment.
Not necessary to include in the repo.
Code/output-dev-formal.txt
Outdated
| @@ -0,0 +1,917 @@ | |||
| . باید جدا بشویم تا فضای بیشتری را بتوانیم چک کنیم | |||
There was a problem hiding this comment.
Not necessary to include in the repo.
Code/output-test-broken.txt
Outdated
| @@ -0,0 +1,1012 @@ | |||
| من مگر این را بهت نگفتم ؟ | |||
There was a problem hiding this comment.
Not necessary to include in the repo.
Code/output-test-formal.txt
Outdated
| @@ -0,0 +1,1012 @@ | |||
| من مگر این را بهت نگفتم ؟ | |||
There was a problem hiding this comment.
Not necessary to include in the repo.
hazm/InformalNormalizer.py
Outdated
| def appendSuffixToWord(OneCollectionOfWordAndSuffix): | ||
| mainWord = OneCollectionOfWordAndSuffix["word"] | ||
| suffixList = OneCollectionOfWordAndSuffix["suffix"] | ||
| adhesiveAlphabet = ["ب", "پ", "ت", "ث", "ج", "چ", "ح", "خ", "س", "ش", "ص", "ض", "ع", "غ", "ف", "ق", "ک", "گ", "ل", "م", "ن", "ه", "ی"] |
There was a problem hiding this comment.
convert it to set for speedup
hazm/InformalNormalizer.py
Outdated
Comment on lines
444
to
449
| # if suffixList[i] == "هاست": | ||
| # for alphabet in adhesiveAlphabet: | ||
| # if returnWord.endswith(alphabet): | ||
| # returnWord += "" | ||
| # break | ||
| # returnWord += "ها است" |
There was a problem hiding this comment.
Please remove comment parts if are no longer needed
Code/standardize.py
Outdated
| @@ -0,0 +1,146 @@ | |||
| # from break_words import * | |||
There was a problem hiding this comment.
This file should not be added to the repository.
eliminate comments eliminate unnecessary files
delete duplicate code
speed up InformalNormalizer
imani
approved these changes
Mar 12, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.