reconcile inconsistencies introduced by MIG Sprint based on old code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIG did not have the latest `controlled-access-terms` applied to the sandbox on which we were doing our work, so some things got a bit duplicated inexactly.
|
Marked this draft because I believe this introduces some new namespaces that need to be defined. Lemme verify and put those in if necessary. |
|
Nevermind. I'm not 100% clear if the keys in settings/authority_sources in fields like this need to be added to the RDF namespace config, or if they are just used for more efficient database storage. The new inclusion of namespace management via UI in the new release will make this easier to handle. |
rosiel
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIG did not have the latest
controlled-access-termsapplied to thesandbox on which we were doing our work, so some things got a bit
duplicated inexactly.
This removes the creation of a new
field_authority_sourcesfield storage and field definition for genre, changing that to use thefield_authority_linklike all the other vocabularies.It is intended to make Islandora#69 merge-ready