-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for config flow option #14
Conversation
I'm almost done with discovery support in the config flow, but I need this change for that. Maybe someone can try it out so we can merge it? |
I've started testing this PR (please resolve the conflicts, BTW), but it does not do anything. Does not import from YAML, does not display Entities... I believe there is some kind of syntax error somewhere. |
I think an import was lost along the way. I fixed the conflict and added the import so it should work now. Feel free to test. But remember that it won't be useful at all for devices added via YAML. If an import for an integration fails it will not be loaded, so that's probably what happened. This is printed to console, at least for me, with no additional configuration. |
Anything in the log? |
Nope. As I wrote, my output is pretty silent when there are certain types of errors... would really love to figure out why. |
I have made a few bug fixes, should work now! |
Seems to be working fine, merging this! |
* change category * abort process if ID Configured * clarify already configured message.
This brings generic support for options to all platforms. It basically triggers the same steps as when adding a new device (with the configured entities). A few things to note:
This change needs some serious testing, so please make sure to test this before merging!